Skip to content

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Sep 5, 2025

Description

Whatever a samm:see reference points to is not considered something that is resolved, even if it happens to be a valid SAMM URN (cf. Definition 15 of Model Resolution). This PR fixes this behavior and removes resolution of URNs that appear in see references.

Fixes #806

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Since AspectWithSee.ttl and AspectWithSeeAttribute.ttl are the same, remove one
of them
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit bad6d2f into eclipse-esmf:main Sep 5, 2025
4 checks passed
@atextor atextor deleted the 806-see-references-to-elements-are-resolved branch September 5, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] samm:see references to model elements are resolved
2 participants